vsquad/elo
3
2
Fork 0
Code Issues 4 Pull Requests Actions Packages Projects 1 Releases Wiki Activity

Refactor PoolMatch #5

Merged
jkassman merged 1 commits from refactor-pool-match into main 2023-12-09 19:09:49 -05:00
Conversation 1 Commits 1 Files Changed 3 +38 -18
jkassman commented 2023-12-09 19:04:37 -05:00
Owner
Copy Link

Co-authored-by: jkassman jkassman@users.noreply.github.com

Co-authored-by: jkassman <jkassman@users.noreply.github.com>
jkassman added 1 commit 2023-12-09 19:04:37 -05:00
Co-authored-by: jkassman <jkassman@users.noreply.github.com>
All checks were successful
Build Crate / build (push) Successful in 8m23s
Details
cd8b52cd29
jkassman requested review from matkam7 2023-12-09 19:07:20 -05:00
matkam7 approved these changes 2023-12-09 19:08:36 -05:00
matkam7 left a comment
Owner
Copy Link

LGTM

LGTM
src/data/pool_match.rs
@@ -19,3 +9,1 @@
winner: PlayerId,
losers: [PlayerId; 2],
},
pub enum MatchType {
matkam7 commented 2023-12-09 19:07:56 -05:00
Owner
Copy Link

Very nice

Very nice
jkassman merged commit cb5da9b966 into main 2023-12-09 19:09:49 -05:00
Sign in to join this conversation.
Reviewers
No Reviewers
matkam7
Labels
Clear labels
Kind/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
jkassman matkam7 why
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: vsquad/elo#5
No description provided.
Delete Branch "refactor-pool-match"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?